fix: preserve error name through the serialization pipeline for proper error rehydration#1504
Draft
fix: preserve error name through the serialization pipeline for proper error rehydration#1504
Conversation
🦋 Changeset detectedLatest commit: a784114 The changes in this PR will be included in the next version bump. This PR includes changesets to release 21 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Copilot
AI
changed the title
[WIP] Add stream pagination and metadata endpoints
fix: preserve error name through the serialization pipeline for proper error rehydration
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WorkflowNotRegisteredErrorandStepNotRegisteredErrorwere introduced in #1452 but the serialization pipeline only storedmessage/stack— dropping the class name. Rehydrated errors were always plainErrorinstances, making.is()checks silently fail.Changes
@workflow/world— Addedname?: stringtoStructuredErrorSchema@workflow/core(runtime) — Includenameinrun_failedevent error objects@workflow/core(step-handler) — StoreStepNotRegisteredErroras{ message, name }object instep_failedevents (was a plain string)@workflow/core(step) — Extractnamefromstep_failederror object and set it on the rejectedFatalError, so.is()checks work inside workflow catch blocks@workflow/errors—WorkflowRunFailedErrornow setscauseError.namefromStructuredError.name, enablingWorkflowNotRegisteredError.is(err.cause)@workflow/world-local,@workflow/world-postgres,@workflow/world-vercel— Preservenamewhen mapping failure events →StructuredError/ JSON serialization round-tripsAfter this change:
How did you test your changes?
step-handler.test.tsassertions to match the new structured error object format forStepNotRegisteredErroreventsstep.test.tsverifying thaterror.nameis preserved fromstep_failedevent data@workflow/core,@workflow/world-local, and@workflow/world-vercelPR Checklist - Required to merge
pnpm changesetwas run to create a changelog for this PRpnpm changeset --emptyif you are changing documentation or workbench appsgit commit --signoffon your commits)@vercel/workflowin a comment once the PR is ready, and the above checklist is completeView original Slack conversation
📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.