Slack: upgrade streamed markdown tables to native blocks#293
Open
mohankumarelec wants to merge 1 commit intovercel:mainfrom
Open
Slack: upgrade streamed markdown tables to native blocks#293mohankumarelec wants to merge 1 commit intovercel:mainfrom
mohankumarelec wants to merge 1 commit intovercel:mainfrom
Conversation
Made-with: Cursor
Contributor
|
@mohankumarelec is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
Collaborator
|
I'm not sure this is desirable. It's a tough one |
Author
|
@cramforce , since slack now supports native markdown table, it has few extra features like rendering large tables in an expanded window, exporting the table in tsv and so on. Do you see downsides of implementing this ? |
Collaborator
|
The main downside is that the shape of the rendering ends at the very end of the stream. So, if you are actually following along you have a janky experience. In fact, we originally did this and it was often jarring. If we knew that nobody was watching, it would definitely be better to use native rendering. |
Author
|
@cramforce , got it , makes sense |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
stopBlockswhen doing that finalchat.updateValidation
pnpm checkpnpm test --filter=@chat-adapter/slack...Small behavior fix, should be safer for current bots too.