Skip to content

Slack: upgrade streamed markdown tables to native blocks#293

Open
mohankumarelec wants to merge 1 commit intovercel:mainfrom
mohankumarelec:fix/slack-stream-table-upgrade
Open

Slack: upgrade streamed markdown tables to native blocks#293
mohankumarelec wants to merge 1 commit intovercel:mainfrom
mohankumarelec:fix/slack-stream-table-upgrade

Conversation

@mohankumarelec
Copy link

@mohankumarelec mohankumarelec commented Mar 24, 2026

What changed

  • upgrades streamed markdown tables into native Slack table blocks once stream is done
  • keeps stopBlocks when doing that final chat.update
  • adds tests for table + no-table stream paths and postMessage behavior

Validation

  • pnpm check
  • pnpm test --filter=@chat-adapter/slack...

Small behavior fix, should be safer for current bots too.

@vercel
Copy link
Contributor

vercel bot commented Mar 24, 2026

@mohankumarelec is attempting to deploy a commit to the Vercel Labs Team on Vercel.

A member of the Team first needs to authorize it.

@cramforce
Copy link
Collaborator

I'm not sure this is desirable. It's a tough one

@mohankumarelec
Copy link
Author

@cramforce , since slack now supports native markdown table, it has few extra features like rendering large tables in an expanded window, exporting the table in tsv and so on.

Do you see downsides of implementing this ?

@cramforce
Copy link
Collaborator

The main downside is that the shape of the rendering ends at the very end of the stream. So, if you are actually following along you have a janky experience.

In fact, we originally did this and it was often jarring. If we knew that nobody was watching, it would definitely be better to use native rendering.

@mohankumarelec
Copy link
Author

@cramforce , got it , makes sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants