Add ability to skip site members and invitations during transfer#6184
Open
Add ability to skip site members and invitations during transfer#6184
Conversation
- Instead of displaying "Accept without members" and "Upgrade to accept" buttons, we now show it in an "Accept" dropdown with these options - Hide notice icon on mobile
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds an option to accept site transfer without transferring any associated guest memberships and invitations. The option is suggested only if accepting user's plan cannot accommodate additional team members from the transferred site. The main purpose of this feature is to ease transferring the sites in cases where the site is carried over to somebody on a single-member starter plan.
Following refactorings were done along the way:
Billing.Quota.ensure_within_plan_limitsacceptskip_*options in a consistent format for all limits (as all of them are used in various contexts.Invitations.accept_transfer_ownershipwas refactored to reduce complexity and improve clarity of the logic, especially with added branchingTests
Documentation
Dark mode