perf: fix macOS spawn latency (~120ms → ~12ms)#1
Open
nicobailon wants to merge 1 commit intopithings:mainfrom
Open
perf: fix macOS spawn latency (~120ms → ~12ms)#1nicobailon wants to merge 1 commit intopithings:mainfrom
nicobailon wants to merge 1 commit intopithings:mainfrom
Conversation
Enumerate /dev/fd instead of brute-force close(3..sysconf limit), which is ~1M no-op syscalls on modern macOS. Also unref Unix exit tsfn to match Windows, cache TextDecoder, add latency benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! Just stumbled onto this:
macOS recently bumped
sysconf(_SC_OPEN_MAX)to1,048,575.closeExcessFdswas callingclose()from 3 to that limit in every child process — over a million no-op syscalls per spawn. Now we enumerate/dev/fdinstead (same approach Linux uses with/proc/self/fd).Minor stuff: unref the Unix exit tsfn (Windows already did this), cache a
TextDecoderin Terminal, and addscripts/bench-latency.ts.