[toast] Add upsert support to add method#4440
Open
atomiks wants to merge 4 commits intomui:masterfrom
Open
Conversation
commit: |
Bundle size report
Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
945e9b7 to
cabaa67
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4228
https://deploy-preview-4440--base-ui.netlify.app/react/components/toast#deduplicated-toast
This adds built-in upsert behavior to
toastManager.add()when callers pass anid, so repeated adds update the existing toast instead of creating a duplicate. Matched toasts keep their identity, refresh their auto-dismiss timer, and a toast that is already ending is replaced with a fresh one instead of being revived mid-dismissal.It also adds
updateKeyto toast objects so custom renderers can replay styles when a toast is updated or upserted. The docs now include a deduplicated toast demo that usesupdateKeyto pulse the existing toast without remounting it.Changes
add({ id })as an upsert in the toast store and incrementupdateKeyon updates and upserts.updateKeychanges onadd()andupdate().idupsert behavior and add a deduplicated toast demo that replays a pulse viaupdateKey.