Conversation
commit: |
Bundle size report
Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codex ReviewOverviewThis PR fixes the current TypeScript 6 validation fallout by centralizing the Findings (None)No blocking issues found in this patch. Confidence: 4/5High confidence based on a full base...head pass over the five touched files, plus targeted checks against repository guidance, nearby history/blame, prior PR context, and the current PR discussion. |
PR Review: [internal] Fix TypeScript 6 validation — #4420Author: @atomiks | Branch: Summary of Changes
AnalysisCorrectness
Docs fix
Potential concerns
CI status: ✅ 23/23 checks pass Merge Readiness Score: 9.5 / 10
Verdict: Ready to merge. The only reason it's not a full 10 is that several requested reviewers (@dav-is, @colmtuite, @michaldudak, @flaviendelangle) haven't weighed in yet, which is a process consideration rather than a code concern. The changes themselves are safe, minimal, and correct. Completed: Present summary and merge readiness (4/4) |
| <Meta | ||
| name="description" | ||
| content="A CSP provider component that applies a nonce to inline <style> and <script> tags rendered by Base UI components, and can disable inline <style> elements." | ||
| content="A CSP provider component that applies a nonce to inline style and script tags rendered by Base UI components, and can disable inline style elements." |
There was a problem hiding this comment.
I think we should keep the non-breaking space
| content="A CSP provider component that applies a nonce to inline style and script tags rendered by Base UI components, and can disable inline style elements." | |
| content="A CSP provider component that applies a nonce to inline style and script tags rendered by Base UI components, and can disable inline style elements." |
This fixes the current TypeScript validation failures that show up with the repo's current toolchain.
The main change is small:
FocusOptionsis augmented in the shared React globals so the existingfocus({ focusVisible: true })calls typecheck again with the DOM typings currently used in this repo. The Vite playground also stops using the deprecatedbaseUrloption.There is one small docs source change as well: the CSP Provider page now avoids raw tag names in its description so docs validation and Vale stay happy under the current docs pipeline.
Changes
focusVisibleto the sharedFocusOptionstyping inpackages/react/src/global.d.ts.baseUrloption from the Vite playground tsconfig.