support icons in context menus#304906
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds icon rendering support to the monaco-menu context menu widget so that actions which already provide an icon CSS class can display that icon in context menus (fixes #304904).
Changes:
- Enable icon rendering for menu items when an action provides a CSS class (icon class).
- Add a dedicated DOM element (
.menu-item-icon) to render the icon separately from the label. - Introduce menu CSS to position/size the icon column and handle disabled/checked visual states.
| } else { | ||
| const keybindingLabel = options.getKeyBinding?.(action)?.getLabel(); | ||
| const menuItemOptions: IMenuItemOptions = { | ||
| enableMnemonics: options.enableMnemonics, | ||
| useEventAsContext: options.useEventAsContext, | ||
| keybinding: keybindingLabel, | ||
| icon: !!action.class, | ||
| }; |
There was a problem hiding this comment.
Icon rendering is only enabled for leaf actions via icon: !!action.class, but SubmenuAction items can also carry an icon class (SubmenuAction.class). Because the submenu branch constructs SubmenuMenuActionViewItem without setting an icon option, submenu entries with icons will still render without icons. Consider passing icon: !!action.class when creating SubmenuMenuActionViewItem (e.g. by spreading options and overriding icon).
There was a problem hiding this comment.
they already work without a change:
fixes #304904
This will add icons support to context menus.
Commands wich have icons will already show them in the context menu.