Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR targets chat “getting started” tips behavior in the workbench chat UI, intended to address tips reappearing after users interact with tip command links (issue #303283).
Changes:
- Update
ChatTipServiceto dismiss the currently shown tip when a command link in the tip is executed. - Adjust existing tests for “settings-link” tips to assert per-tip dismissal persistence.
- Add a new test ensuring the
/create-prompttip is dismissed after its command link is invoked.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/vs/workbench/contrib/chat/browser/chatTipService.ts |
Changes tip command-link handling to always dismiss the shown tip (and removes prior session-hiding behavior). |
src/vs/workbench/contrib/chat/test/browser/chatTipService.test.ts |
Updates dismissal expectations for command-link interactions and adds coverage for tip.createPrompt. |
justschen
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #303283