Skip to content

Fix forEach(async ...) causing fire-and-forget promises in notebook code #304898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pefia wants to merge 2 commits into
base: main
Choose a base branch
from
+11 −11
Open

Fix forEach(async ...) causing fire-and-forget promises in notebook code #304898

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14df17f
Fix forEach(async ...) causing fire-and-forget promises in notebook code
pefia Mar 25, 2026
c3d5d1b
Update src/vs/workbench/contrib/notebook/browser/contrib/multicursor/…
pefia Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/vs/workbench/contrib/notebook/browser/contrib/multicursor/notebookMulticursor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,18 +448,18 @@ export class NotebookMultiCursorController extends Disposable implements INotebo
code: 'multiCursorEdit',
confirmBeforeUndo: false,
undo: async () => {
newElementsMap.forEach(async value => {
value.reverse().forEach(async element => {
for (const value of newElementsMap.values()) {
for (const element of value.reverse()) {
await element.undo();
});
});
}
}
},
redo: async () => {
newElementsMap.forEach(async value => {
value.forEach(async element => {
for (const value of newElementsMap.values()) {
for (const element of value) {
await element.redo();
});
});
}
}
}
});
}
Expand Down
4 changes: 2 additions & 2 deletions src/vs/workbench/contrib/notebook/browser/controller/editActions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -690,7 +690,7 @@ registerAction2(class CommentSelectedCellsAction extends NotebookMultiCellAction
async runWithContext(accessor: ServicesAccessor, context: INotebookCommandContext): Promise<void> {
const languageConfigurationService = accessor.get(ILanguageConfigurationService);

context.selectedCells.forEach(async cellViewModel => {
for (const cellViewModel of context.selectedCells) {
const textModel = await cellViewModel.resolveTextModel();

const commentsOptions = cellViewModel.commentOptions;
Expand Down Expand Up @@ -718,7 +718,7 @@ registerAction2(class CommentSelectedCellsAction extends NotebookMultiCellAction
return new Selection(range.startLineNumber, range.startColumn, range.endLineNumber, range.endColumn);
});
cellViewModel.setSelections(newTrackedSelections ?? []);
}); // end of cells forEach
}
}

});
Loading