-
Notifications
You must be signed in to change notification settings - Fork 38.8k
sessions first time use #304893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+483
−8
Closed
sessions first time use #304893
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -69,7 +69,7 @@ class ActionWidgetService extends Disposable implements IActionWidgetService { | |||||||||||||||||
| getAnchor: () => anchor, | ||||||||||||||||||
| render: (container: HTMLElement) => { | ||||||||||||||||||
| visibleContext.set(true); | ||||||||||||||||||
| return this._renderWidget(container, list, actionBarActions ?? []); | ||||||||||||||||||
| return this._renderWidget(container, list, actionBarActions ?? [], user); | ||||||||||||||||||
| }, | ||||||||||||||||||
| onHide: (didCancel) => { | ||||||||||||||||||
| visibleContext.reset(); | ||||||||||||||||||
|
|
@@ -116,7 +116,7 @@ class ActionWidgetService extends Disposable implements IActionWidgetService { | |||||||||||||||||
| this._list.clear(); | ||||||||||||||||||
| } | ||||||||||||||||||
|
|
||||||||||||||||||
| private _renderWidget(element: HTMLElement, list: ActionList<unknown>, actionBarActions: readonly IAction[]): IDisposable { | ||||||||||||||||||
| private _renderWidget(element: HTMLElement, list: ActionList<unknown>, actionBarActions: readonly IAction[], user: string): IDisposable { | ||||||||||||||||||
| const widget = document.createElement('div'); | ||||||||||||||||||
| widget.classList.add('action-widget'); | ||||||||||||||||||
| element.appendChild(widget); | ||||||||||||||||||
|
|
@@ -136,7 +136,14 @@ class ActionWidgetService extends Disposable implements IActionWidgetService { | |||||||||||||||||
| const menuBlock = document.createElement('div'); | ||||||||||||||||||
| const block = element.appendChild(menuBlock); | ||||||||||||||||||
| block.classList.add('context-view-block'); | ||||||||||||||||||
| renderDisposables.add(dom.addDisposableListener(block, dom.EventType.MOUSE_DOWN, e => e.stopPropagation())); | ||||||||||||||||||
|
|
||||||||||||||||||
| if (user === 'workspacePicker') { | ||||||||||||||||||
| // Allow interactions with the sessions workspace tutorial callout, | ||||||||||||||||||
| // which is rendered alongside the action widget while this picker is open. | ||||||||||||||||||
| block.style.pointerEvents = 'none'; | ||||||||||||||||||
| } else { | ||||||||||||||||||
| renderDisposables.add(dom.addDisposableListener(block, dom.EventType.MOUSE_DOWN, e => e.stopPropagation())); | ||||||||||||||||||
| } | ||||||||||||||||||
|
Comment on lines
+140
to
+146
|
||||||||||||||||||
| if (user === 'workspacePicker') { | |
| // Allow interactions with the sessions workspace tutorial callout, | |
| // which is rendered alongside the action widget while this picker is open. | |
| block.style.pointerEvents = 'none'; | |
| } else { | |
| renderDisposables.add(dom.addDisposableListener(block, dom.EventType.MOUSE_DOWN, e => e.stopPropagation())); | |
| } | |
| renderDisposables.add(dom.addDisposableListener(block, dom.EventType.MOUSE_DOWN, e => e.stopPropagation())); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
184 changes: 184 additions & 0 deletions
184
src/vs/sessions/contrib/chat/browser/media/workspacePickerCallout.css
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,184 @@ | ||
| /*--------------------------------------------------------------------------------------------- | ||
| * Copyright (c) Microsoft Corporation. All rights reserved. | ||
| * Licensed under the MIT License. See License.txt in the project root for license information. | ||
| *--------------------------------------------------------------------------------------------*/ | ||
|
|
||
| /* Callout container */ | ||
| .workspace-picker-callout { | ||
| position: absolute; | ||
| top: 100%; | ||
| left: calc(100% + 14px); | ||
| width: 280px; | ||
| z-index: 100; | ||
|
|
||
| background-color: var(--vscode-editorWidget-background); | ||
| border: 1px solid var(--vscode-editorWidget-border, var(--vscode-contrastBorder, transparent)); | ||
| border-radius: 8px; | ||
| box-shadow: 0 4px 16px rgba(0, 0, 0, 0.16); | ||
|
|
||
| animation: workspace-callout-fade-in 0.2s ease both; | ||
| } | ||
|
|
||
| .workspace-picker-callout.hiding { | ||
| animation: workspace-callout-fade-out 0.15s ease both; | ||
| } | ||
|
|
||
| @keyframes workspace-callout-fade-in { | ||
| from { | ||
| opacity: 0; | ||
| transform: translateX(4px); | ||
| } | ||
| to { | ||
| opacity: 1; | ||
| transform: translateX(0); | ||
| } | ||
| } | ||
|
|
||
| @keyframes workspace-callout-fade-out { | ||
| from { | ||
| opacity: 1; | ||
| transform: translateX(0); | ||
| } | ||
| to { | ||
| opacity: 0; | ||
| transform: translateX(4px); | ||
| } | ||
| } | ||
|
|
||
| /* Pointer arrow (left-pointing) */ | ||
| .workspace-picker-callout-pointer { | ||
| position: absolute; | ||
| left: -6px; | ||
| top: 24px; | ||
| transform: rotate(45deg); | ||
| width: 10px; | ||
| height: 10px; | ||
| background-color: var(--vscode-editorWidget-background); | ||
| border-bottom: 1px solid var(--vscode-editorWidget-border, var(--vscode-contrastBorder, transparent)); | ||
| border-left: 1px solid var(--vscode-editorWidget-border, var(--vscode-contrastBorder, transparent)); | ||
| } | ||
|
|
||
| /* Header bar (dismiss + snooze) */ | ||
| .workspace-picker-callout-header { | ||
| display: flex; | ||
| justify-content: flex-end; | ||
| align-items: center; | ||
| gap: 2px; | ||
| padding: 6px 6px 0 6px; | ||
| } | ||
|
|
||
| .workspace-picker-callout-header button { | ||
| display: flex; | ||
| align-items: center; | ||
| justify-content: center; | ||
| width: 22px; | ||
| height: 22px; | ||
| border: none; | ||
| border-radius: 4px; | ||
| background-color: transparent; | ||
| color: var(--vscode-descriptionForeground); | ||
| cursor: pointer; | ||
| } | ||
|
|
||
| .workspace-picker-callout-header button:hover { | ||
| background-color: var(--vscode-toolbar-hoverBackground); | ||
| color: var(--vscode-foreground); | ||
| } | ||
|
|
||
| .workspace-picker-callout-header button .codicon { | ||
| font-size: 14px; | ||
| } | ||
|
|
||
| /* Body */ | ||
| .workspace-picker-callout-body { | ||
| padding: 4px 14px 12px 14px; | ||
| } | ||
|
|
||
| /* Description lines */ | ||
| .workspace-picker-callout-description { | ||
| display: flex; | ||
| flex-direction: column; | ||
| gap: 8px; | ||
| } | ||
|
|
||
| .workspace-picker-callout-line { | ||
| display: flex; | ||
| align-items: flex-start; | ||
| gap: 8px; | ||
| font-size: 13px; | ||
| line-height: 1.45; | ||
| color: var(--vscode-foreground); | ||
| } | ||
|
|
||
| .workspace-picker-callout-icon { | ||
| flex-shrink: 0; | ||
| display: flex; | ||
| align-items: center; | ||
| justify-content: center; | ||
| width: 18px; | ||
| height: 19px; /* align with first line of text */ | ||
| } | ||
|
|
||
| .workspace-picker-callout-icon .codicon { | ||
| font-size: 14px; | ||
| color: var(--vscode-descriptionForeground); | ||
| } | ||
|
|
||
| /* FAQ */ | ||
| .workspace-picker-callout-faq { | ||
| margin-top: 12px; | ||
| border-top: 1px solid var(--vscode-editorWidget-border, var(--vscode-contrastBorder, transparent)); | ||
| padding-top: 8px; | ||
| } | ||
|
|
||
| .workspace-picker-callout-faq-item { | ||
| margin: 0; | ||
| } | ||
|
|
||
| .workspace-picker-callout-faq-item + .workspace-picker-callout-faq-item { | ||
| margin-top: 2px; | ||
| } | ||
|
|
||
| .workspace-picker-callout-faq-question { | ||
| font-size: 12px; | ||
| font-weight: 600; | ||
| color: var(--vscode-foreground); | ||
| cursor: pointer; | ||
| list-style: none; | ||
| padding: 4px 4px; | ||
| border-radius: 4px; | ||
| user-select: none; | ||
| -webkit-user-select: none; | ||
| } | ||
|
|
||
| .workspace-picker-callout-faq-question::-webkit-details-marker { | ||
| display: none; | ||
| } | ||
|
|
||
| .workspace-picker-callout-faq-question::before { | ||
| content: ''; | ||
| display: inline-block; | ||
| width: 0; | ||
| height: 0; | ||
| border-style: solid; | ||
| border-width: 4px 0 4px 6px; | ||
| border-color: transparent transparent transparent var(--vscode-descriptionForeground); | ||
| margin-right: 6px; | ||
| vertical-align: middle; | ||
| transition: transform 0.15s ease; | ||
| } | ||
|
|
||
| details[open].workspace-picker-callout-faq-item > .workspace-picker-callout-faq-question::before { | ||
| transform: rotate(90deg); | ||
| } | ||
|
|
||
| .workspace-picker-callout-faq-question:hover { | ||
| background-color: var(--vscode-toolbar-hoverBackground); | ||
| } | ||
|
|
||
| .workspace-picker-callout-faq-answer { | ||
| font-size: 12px; | ||
| line-height: 1.5; | ||
| color: var(--vscode-descriptionForeground); | ||
| padding: 4px 4px 8px 16px; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Special-casing behavior based on the magic
user === 'workspacePicker'string is fragile (easy to mistype and not discoverable to other callers). Consider using a typed options argument (e.g.{ allowCompanionElementSelector: ... }/{ allowOutsideInteractionWith: ... }) or a shared constant/enum so this coupling is explicit and maintainable.