Fix hintTimer disposal leak and restore tooltip live-update during active display#304891
Draft
Copilot wants to merge 2 commits intoeli/update-stylingfrom
Draft
Conversation
… update when visible Agent-Logs-Url: https://github.com/microsoft/vscode/sessions/80e0945f-2ac9-4439-bbf6-21f3e0bf00ff Co-authored-by: eli-w-king <201316543+eli-w-king@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions workflow for Code OSS
Fix hintTimer disposal leak and restore tooltip live-update during active display
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three issues in
updateTitleBarEntry.tsintroduced by the styling rework:Memory leak:
hintTimer(asetTimeouthandle) was never cleared on disposal. Added atoDisposableregistration in the constructor to clear it.Unsafe non-null assertion:
this.content!in theflashHintOnceasync callback could be stale by the time the timer fires. Capturedcontentas a local variable before scheduling.Tooltip staleness regression:
onStateChangewas refactored to combine early-return conditions, inadvertently dropping thethis.tooltip.renderState(this.state)call for thetooltipVisible/ no-focus path. This broke live updates (e.g., download progress) while the tooltip is open. Restored the original behavior.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/graphql/usr/bin/gh gh run view 23560432186 --json jobs --jq .jobs[] | select(.conclusion == "failure") | {name: .name, id: .databaseId} : if 'hygiene' in l.lower() or 'lint' in l.lower(): print(f'{i}: {l}')(http block)https://api.github.com/repos/microsoft/vscode/actions/jobs/68598610598/logs/usr/bin/gh gh api repos/microsoft/vscode/actions/jobs/68598610598/logs(http block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.