Copilot CLI: Handle errors during tool invocation formatting

[DonJayamanne]

No description provided.

[Copilot]

Pull request overview

This PR improves resilience of Copilot CLI chat tool-invocation rendering by catching exceptions thrown by tool invocation formatters so a single formatter bug doesn’t break the overall session UI.

Changes:

• Wrap tool completion “post formatter” execution in a try/catch and attempt a generic completion fallback on failure.
• Wrap tool invocation “pre formatter” execution in a try/catch and (optionally) log formatter failures.
• Extend createCopilotCLIToolInvocation(...) to accept an optional ILogger for error reporting.

Comments suppressed due to low confidence (2)

src/extension/chatSessions/copilotcli/common/copilotCLITools.ts:933

• createCopilotCLIToolInvocation now swallows formatter exceptions, but if the formatter throws before setting invocationMessage/pastTenseMessage/toolSpecificData, the UI may show a blank or unhelpful tool invocation. Consider setting a generic Using tool: ... / Used tool: ... message (and optionally input args) before calling the formatter, and in the catch block ensure a minimal fallback display is filled in (not just logging).

	try {
		(formatter as Formatter)(invocation, toolCall, editId, workingDirectory);
	} catch (err) {
		logger?.error(err, `Failed to format tool invocation for tool: ${toolCall.toolName}`);
	}

src/extension/chatSessions/copilotcli/common/copilotCLITools.ts:884

• The new optional logger parameter isn’t currently passed by any call sites in this module (e.g. processToolExecutionStart still calls createCopilotCLIToolInvocation(..., editId, workingDirectory)), so formatter errors will generally be swallowed without any log in production. Either plumb an ILogger down from the caller (and/or make it required) or use an existing logger available in this codepath so failures are observable.

export function createCopilotCLIToolInvocation(data: {
	toolCallId: string; toolName: string; arguments?: unknown; mcpServerName?: string | undefined;
	mcpToolName?: string | undefined;
}, editId?: string, workingDirectory?: URI, logger?: ILogger): ChatToolInvocationPart | ChatResponseMarkdownPart | ChatResponseThinkingProgressPart | undefined {