Dockerfile - Add ROCm6.3 dockerfile by polarG · Pull Request #790 · microsoft/superbenchmark

polarG · 2026-03-16T05:01:17Z

Description
Add ROCm6.3 dockerfile.

Copilot

Pull request overview

Adds a new ROCm 6.3 container recipe to the repo’s dockerfile/ collection, targeting the rocm/pytorch-training:v25.6 base image and layering SuperBench build/install steps plus common tooling needed for benchmarks.

Changes:

Introduces dockerfile/rocm6.3.x.dockerfile for a ROCm 6.3.4 + PyTorch training base image.
Installs additional system tools (Docker client, OFED if missing, Intel MLC) and configures SSH/limits.
Builds SuperBench third-party dependencies and installs the package with AMD worker extras.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

dockerfile/rocm6.3.x.dockerfile

+ARG NUM_MAKE_JOBS=64
+


dockerfile/rocm6.3.x.dockerfile

+ENV USE_HIPBLAS_COMPUTETYPE=1
+RUN python3 -m pip install --no-build-isolation .[amdworker]  && \
+    CXX=/opt/rocm/bin/hipcc make cppbuild  && \
+    make postinstall


dockerfile/rocm6.3.x.dockerfile

+# Get Ubuntu version and set as an environment variable
+RUN echo "Ubuntu version: $(lsb_release -r -s)"
+ARG UBUNTU_VERSION=22.04
+
+# Install OFED
+ENV OFED_VERSION=24.10-1.1.4.0
+# Check if ofed_info is present and has a version
+RUN if ! command -v ofed_info >/dev/null 2>&1; then \
+    echo "OFED not found. Installing OFED..."; \


dockerfile/rocm6.3.x.dockerfile

+RUN python3 -m pip install --upgrade pip wheel setuptools==65.7 && \
+    python3 -c "import pkg_resources" || python3 -m pip install setuptools
+


dockerfile/rocm6.3.x.dockerfile

+RUN if ! command -v ofed_info >/dev/null 2>&1; then \
+    echo "OFED not found. Installing OFED..."; \
+    cd /tmp && \
+    wget -q http://content.mellanox.com/ofed/MLNX_OFED-${OFED_VERSION}/MLNX_OFED_LINUX-${OFED_VERSION}-ubuntu${UBUNTU_VERSION}-x86_64.tgz && \


dockerfile/rocm6.3.x.dockerfile

+# Upgrading botocore/boto3 to versions compatible with urllib3 2.x.
+RUN python3 -m pip install --upgrade botocore boto3


codecov · 2026-03-16T05:09:31Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.16%. Comparing base (6b8e810) to head (8e7e740).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #790      +/-   ##
==========================================
- Coverage   85.70%   85.16%   -0.55%     
==========================================
  Files         102      103       +1     
  Lines        7703     8298     +595     
==========================================
+ Hits         6602     7067     +465     
- Misses       1101     1231     +130

Flag	Coverage Δ
cpu-python3.10-unit-test	`70.42% <ø> (-0.54%)`	⬇️
cpu-python3.7-unit-test	`69.85% <ø> (-0.59%)`	⬇️
cuda-unit-test	`83.60% <ø> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot

Pull request overview

Adds a new ROCm 6.3 build target to the repository’s Docker image build pipeline, enabling CI to produce a superbench/main:rocm6.3 image variant.

Changes:

Introduces dockerfile/rocm6.3.x.dockerfile based on rocm/pytorch-training:v25.6, with additional system deps, Docker CLI, OFED (conditional), and SuperBench build/install steps.
Updates .github/workflows/build-image.yml to build and tag the new ROCm 6.3 image on the self-hosted ROCm runner.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.

File	Description
dockerfile/rocm6.3.x.dockerfile	New ROCm 6.3 Dockerfile building SuperBench on top of `rocm/pytorch-training:v25.6`.
.github/workflows/build-image.yml	Adds a `rocm6.3` entry to the build matrix to produce/push `superbench/main:rocm6.3`.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

dockerfile/rocm6.3.x.dockerfile

+
+ADD third_party third_party
+# perftest_rocm6.patch skipped — upstream perftest already includes the equivalent changes
+RUN make RCCL_HOME=/opt/rocm ROCBLAS_BRANCH=release-staging/rocm-rel-6.3 HIPBLASLT_BRANCH=release-staging/rocm-rel-6.3 ROCM_VER=rocm-5.5.0 -C third_party rocm -o cpu_hpl -o cpu_stream -o megatron_lm -o rocm_megatron_lm


dockerfile/rocm6.3.x.dockerfile

+    sed -i "s/[# ]*PermitRootLogin prohibit-password/PermitRootLogin yes/" /etc/ssh/sshd_config && \
+    sed -i "s/[# ]*PermitUserEnvironment no/PermitUserEnvironment yes/" /etc/ssh/sshd_config && \
+    sed -i "s/[# ]*Port.*/Port 22/" /etc/ssh/sshd_config && \
+    echo "* soft nofile 1048576\n* hard nofile 1048576" >> /etc/security/limits.conf && \
+    echo "root soft nofile 1048576\nroot hard nofile 1048576" >> /etc/security/limits.conf


dockerfile/rocm6.3.x.dockerfile

+
+# Install OFED
+ENV OFED_VERSION=24.10-1.1.4.0
+# Check if ofed_info is present and has a version


dockerfile/rocm6.3.x.dockerfile

+ADD . .
+ENV USE_HIP_DATATYPE=1
+ENV USE_HIPBLAS_COMPUTETYPE=1
+RUN python3 -m pip install --no-build-isolation .[amdworker]  && \
+    CXX=/opt/rocm/bin/hipcc make cppbuild  && \
+    make postinstall


dockerfile/rocm6.3.x.dockerfile

+RUN python3 -m pip install --upgrade pip wheel setuptools==65.7 && \
+    python3 -c "import pkg_resources" || python3 -m pip install setuptools


dockerfile/rocm6.3.x.dockerfile

+ENV OFED_VERSION=24.10-1.1.4.0
+# Check if ofed_info is present and has a version
+RUN if ! command -v ofed_info >/dev/null 2>&1; then \
+    echo "OFED not found. Installing OFED..."; \
+    cd /tmp && \
+    wget -q http://content.mellanox.com/ofed/MLNX_OFED-${OFED_VERSION}/MLNX_OFED_LINUX-${OFED_VERSION}-ubuntu${UBUNTU_VERSION}-x86_64.tgz && \


Copilot

Pull request overview

Adds a new ROCm 6.3 container build path to the repo, and updates third-party build logic to support explicit ROCm GPU arch selection during rccl-tests compilation.

Changes:

Add dockerfile/rocm6.3.x.dockerfile based on rocm/pytorch-training:v25.6 and install additional tooling (Docker client, OFED, MLC).
Update third_party/Makefile to optionally build rccl-tests with explicit --offload-arch flags when AMDGPU_TARGETS is provided.
Update the GitHub Actions image build matrix to include a rocm6.3 build.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File	Description
third_party/Makefile	Adds conditional arch-aware `rccl-tests` build flags driven by `AMDGPU_TARGETS`.
dockerfile/rocm6.3.x.dockerfile	Introduces a new ROCm 6.3 image definition and wires in third-party builds and package installs.
.github/workflows/build-image.yml	Adds the new `rocm6.3` image to CI build/push matrix.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-25T22:19:41Z

dockerfile/rocm6.3.x.dockerfile

+    wget -q http://content.mellanox.com/ofed/MLNX_OFED-${OFED_VERSION}/MLNX_OFED_LINUX-${OFED_VERSION}-ubuntu${UBUNTU_VERSION}-x86_64.tgz && \
+    tar xzf MLNX_OFED_LINUX-${OFED_VERSION}-ubuntu${UBUNTU_VERSION}-x86_64.tgz && \
+    PATH=/usr/bin:${PATH} MLNX_OFED_LINUX-${OFED_VERSION}-ubuntu${UBUNTU_VERSION}-x86_64/mlnxofedinstall --user-space-only --without-fw-update --force --all && \
+    rm -rf MLNX_OFED_LINUX-${OFED_VERSION}* ; \
+    fi


The OFED tarball is downloaded over plain HTTP, which is vulnerable to MITM tampering during the image build. Prefer HTTPS if available and consider verifying the downloaded artifact (checksum/signature) before executing the installer.

Copilot · 2026-03-25T22:19:42Z

dockerfile/rocm6.3.x.dockerfile

+ENV USE_HIPBLAS_COMPUTETYPE=1
+RUN python3 -m pip install --no-build-isolation .[amdworker]  && \
+    CXX=/opt/rocm/bin/hipcc make cppbuild  && \
+    make postinstall


After ADD . ., this Dockerfile doesn’t remove the .git directory. In this repo the build context includes .git (see existing CUDA/ROCm Dockerfiles which rm -rf .git at the end), so leaving it inflates the final image size and can slow pushes/pulls. Consider deleting .git in the final layer after postinstall.

Suggested change

make postinstall

make postinstall && \

rm -rf .git

Copilot · 2026-03-25T22:19:42Z

third_party/Makefile

+ifdef AMDGPU_TARGETS
+	cd ./rccl-tests && make MPI=1 MPI_HOME=$(MPI_HOME) HIPCUFLAGS="-std=c++14 -O3 $(ROCM_OFFLOAD_ARCH_FLAGS) -I$(ROCM_PATH)/include -I$(ROCM_PATH)/include/rccl -I$(ROCM_PATH)/include/hip -DMPI_SUPPORT -I$(MPI_HOME)/include -I$(MPI_HOME)/include/mpi" -j
+else
 	cd ./rccl-tests && make MPI=1 MPI_HOME=$(MPI_HOME) -j
+endif


ifdef AMDGPU_TARGETS triggers when the variable is defined even if it’s empty, which can unexpectedly switch to the HIPCUFLAGS path and potentially break the build. Consider switching the condition to a non-empty check (e.g., using ifneq ($(strip $(AMDGPU_TARGETS)),)), so the fallback path is used when it’s unset or blank.

Copilot · 2026-03-25T22:19:42Z

dockerfile/rocm6.3.x.dockerfile

+# Upgrading botocore/boto3 to versions compatible with urllib3 2.x.
+RUN python3 -m pip install --upgrade botocore boto3


This upgrades botocore/boto3 to whatever the latest versions are at build time, which makes the image non-reproducible and can break future builds unexpectedly. Consider pinning to known-good versions that are compatible with urllib3 2.x (and optionally using --no-cache-dir).

Suggested change

# Upgrading botocore/boto3 to versions compatible with urllib3 2.x.

RUN python3 -m pip install --upgrade botocore boto3

# Upgrade botocore/boto3 to specific versions compatible with urllib3 2.x.

RUN python3 -m pip install --no-cache-dir "botocore==1.35.98" "boto3==1.35.98"

Copilot · 2026-03-25T22:19:42Z

dockerfile/rocm6.3.x.dockerfile

+ARG NUM_MAKE_JOBS=64
+
+# Install Docker
+ENV DOCKER_VERSION=27.5.1
+RUN cd /tmp && \


NUM_MAKE_JOBS is declared as a build arg here but isn’t referenced anywhere in this Dockerfile, so the workflow’s build_args: NUM_MAKE_JOBS=... has no effect. Either remove the ARG or wire it into the build steps (e.g., pass it to make -j / cmake builds) to make parallelism configurable.

Suggested change

ARG NUM_MAKE_JOBS=64

# Install Docker

ENV DOCKER_VERSION=27.5.1

RUN cd /tmp && \

# Install Docker

ENV DOCKER_VERSION=27.5.1

RUN cd /tmp && \

RUN cd /tmp && \

Add rocm6.3.x dockerfile.

c522d3e

Copilot AI review requested due to automatic review settings March 16, 2026 05:01

polarG requested a review from a team as a code owner March 16, 2026 05:01

Copilot started reviewing on behalf of polarG March 16, 2026 05:01 View session

polarG self-assigned this Mar 16, 2026

polarG requested review from abuccts and guoshzhao March 16, 2026 05:02

polarG added ROCm enhancement New feature or request labels Mar 16, 2026

Copilot AI reviewed Mar 16, 2026

View reviewed changes

Hongtao Zhang added 2 commits March 16, 2026 05:10

Add CICD build verification.

7f7316a

Update.

32471dd

Copilot AI review requested due to automatic review settings March 16, 2026 18:52

Copilot started reviewing on behalf of polarG March 16, 2026 18:52 View session

Copilot AI reviewed Mar 16, 2026

View reviewed changes

Hongtao Zhang added 2 commits March 17, 2026 17:34

Anchor GPU supported GPU archs in dockerfile.

455a503

Remove deepspeed path since the base image already have it.

8e7e740

Copilot AI review requested due to automatic review settings March 25, 2026 22:15

Copilot started reviewing on behalf of polarG March 25, 2026 22:16 View session

Copilot AI reviewed Mar 25, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dockerfile - Add ROCm6.3 dockerfile#790

Dockerfile - Add ROCm6.3 dockerfile#790
polarG wants to merge 5 commits intomainfrom
dev/hongtaozhang/add-dockerfile-rocm-6.3.x

polarG commented Mar 16, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

codecov bot commented Mar 16, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 25, 2026

Uh oh!

Copilot AI Mar 25, 2026

Uh oh!

Copilot AI Mar 25, 2026

Uh oh!

Copilot AI Mar 25, 2026

Uh oh!

Copilot AI Mar 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		RUN python3 -m pip install --upgrade pip wheel setuptools==65.7 && \
		python3 -c "import pkg_resources" \|\| python3 -m pip install setuptools

		# Upgrading botocore/boto3 to versions compatible with urllib3 2.x.
		RUN python3 -m pip install --upgrade botocore boto3

Conversation

polarG commented Mar 16, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

codecov bot commented Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov bot commented Mar 16, 2026 •

edited

Loading