feat(react-select): add useSelectBase_unstable hook#35906
Draft
dmytrokirpa wants to merge 1 commit intomicrosoft:masterfrom
Draft
feat(react-select): add useSelectBase_unstable hook#35906dmytrokirpa wants to merge 1 commit intomicrosoft:masterfrom
dmytrokirpa wants to merge 1 commit intomicrosoft:masterfrom
Conversation
Adds `useSelectBase_unstable` hook and `SelectBaseProps`/`SelectBaseState` types that expose the core slot/event logic without design-specific props (`appearance`, `size`). The styled `useSelect_unstable` now delegates to the base hook and applies defaults (ChevronDownRegular icon, field control props, overrides). Updates `renderSelect_unstable` to accept `SelectBaseState`. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
📊 Bundle size report
Unchanged fixtures
|
|
Pull request demo site: URL |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵🏾♀️ visual changes to review in the Visual Change Report
vr-tests-react-components/Avatar Converged 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Avatar Converged.badgeMask.normal.chromium.png | 3 | Changed |
vr-tests-react-components/Charts-DonutChart 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Charts-DonutChart.Dynamic.default.chromium.png | 5581 | Changed |
vr-tests-react-components/Menu Converged - submenuIndicator slotted content 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Menu Converged - submenuIndicator slotted content.default - RTL.submenus open.chromium.png | 404 | Changed |
| vr-tests-react-components/Menu Converged - submenuIndicator slotted content.default.submenus open.chromium.png | 413 | Changed |
vr-tests-react-components/Positioning 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Positioning.Positioning end.chromium.png | 620 | Changed |
| vr-tests-react-components/Positioning.Positioning end.updated 2 times.chromium.png | 35 | Changed |
vr-tests-react-components/TagPicker 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/TagPicker.disabled - RTL.chromium.png | 635 | Changed |
| vr-tests-react-components/TagPicker.disabled.disabled input hover.chromium.png | 677 | Changed |
There were 2 duplicate changes discarded. Check the build logs for more information.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useSelectBase_unstablehook that exposes the core slot/ARIA/event logic ofSelectwithout design-specific props (appearance,size)SelectBasePropsandSelectBaseStatetypes (DistributiveOmit<..., 'appearance' | 'size'>)useSelect_unstableto delegate to the base hook, then layer on field control props, overrides, and theChevronDownRegularicon defaultrenderSelect_unstableto acceptSelectBaseState(render only uses slot props, not design props)Test plan
yarn nx build react-select— passes, API md updatedyarn nx lint react-select— passesyarn nx test react-select— 29 tests passPart of #35562
🤖 Generated with Claude Code