test(tree): Add simple plain text insert/remove character op-size benchmark tests#26840
Open
Josmithr wants to merge 6 commits intomicrosoft:mainfrom
Open
test(tree): Add simple plain text insert/remove character op-size benchmark tests#26840Josmithr wants to merge 6 commits intomicrosoft:mainfrom
Josmithr wants to merge 6 commits intomicrosoft:mainfrom
Conversation
Josmithr
commented
Mar 25, 2026
| * Licensed under the MIT License. | ||
| */ | ||
|
|
||
| import type { ISequencedDocumentMessage } from "@fluidframework/driver-definitions/internal"; |
Contributor
Author
There was a problem hiding this comment.
Note for reviewers: this code was extracted from opSize.bench.ts for reuse.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds op-size benchmark coverage for the TextDomain plain-text editing path, and factors common op-capture/stat logic into a shared utility to reuse across benchmark suites.
Changes:
- Add new
TextDomain benchmarksfor inserting/removing a single character in short and long strings, reporting total/max op sizes and op count. - Extract
createConnectedTree,registerOpListener, and op-size stats helpers into a newopBenchmarkUtilities.ts. - Refactor
opSize.bench.tsto use the shared utilities and remove duplicated helper code/imports.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/dds/tree/src/test/shared-tree/textDomain.bench.ts | New measurement benchmarks for single-character insert/remove in TextAsTree, reporting op-size stats. |
| packages/dds/tree/src/test/shared-tree/opSize.bench.ts | Removes locally-defined op-capture/stats helpers in favor of the shared benchmark utilities. |
| packages/dds/tree/src/test/shared-tree/opBenchmarkUtilities.ts | Introduces shared helpers for creating a connected test tree, capturing submitted ops, and computing op-size stats. |
Also reverts type change, which broke indexing pattern
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Insert character
Remove character