-
Notifications
You must be signed in to change notification settings - Fork 442
Open
Description
For packaging purposes I build CIRCT against standalone LLVM and MLIR packages.
Recent circt-tblgen tests now grab headers out of the llvm submodule directly, which doesn't work if you don't have that submodule and expect to be getting them from the system. (And more to the point, if you configure CIRCT to build using a particular system LLVM/MLIR, we should be using those headers regardless)
One suggested resolution path is obtaining the MLIR paths from CMake, and injecting into lit (lit.site.cfg.py.in) and using those in the tests.
Failing tests:
CIRCT :: Tools/circt-tblgen/rtg-instruction-methods-errors.td
CIRCT :: Tools/circt-tblgen/rtg-instruction-methods.td
Test output:
FAIL: CIRCT :: Tools/circt-tblgen/rtg-instruction-methods.td (810 of 1125)
******************** TEST 'CIRCT :: Tools/circt-tblgen/rtg-instruction-methods.td' FAILED ********************
Exit Code: 2
Command Output (stderr):
--
RUN: at line 1: circt-tblgen -gen-rtg-instruction-methods -I /build/source/test/Tools/circt-tblgen/../../../include -I /build/source/test/Tools/circt-tblgen/../../../llvm/mlir/include /build/source/test/Tools/circt-tblgen/rtg-instruction-methods.td | /nix/store/0y8ygxmgwq4xsrqpjidrbnc77k2yx40y-llvm-23.0.0-20260129_52dfcab/bin/FileCheck /build/source/test/Tools/circt-tblgen/rtg-instruction-methods.td
+ circt-tblgen -gen-rtg-instruction-methods -I /build/source/test/Tools/circt-tblgen/../../../include -I /build/source/test/Tools/circt-tblgen/../../../llvm/mlir/include /build/source/test/Tools/circt-tblgen/rtg-instruction-methods.td
+ /nix/store/0y8ygxmgwq4xsrqpjidrbnc77k2yx40y-llvm-23.0.0-20260129_52dfcab/bin/FileCheck /build/source/test/Tools/circt-tblgen/rtg-instruction-methods.td
/build/source/test/Tools/circt-tblgen/rtg-instruction-methods.td:3:9: error: could not find include file 'mlir/IR/OpBase.td'
include "mlir/IR/OpBase.td"
¦ ¦ ¦ ^
/build/source/test/Tools/circt-tblgen/rtg-instruction-methods.td:3:9: error: Unexpected token at top level
include "mlir/IR/OpBase.td"
¦ ¦ ¦ ^
FileCheck error: '<stdin>' is empty.
FileCheck command line: /nix/store/0y8ygxmgwq4xsrqpjidrbnc77k2yx40y-llvm-23.0.0-20260129_52dfcab/bin/FileCheck /build/source/test/Tools/circt-tblgen/rtg-instruction-methods.td
--
and
FAIL: CIRCT :: Tools/circt-tblgen/rtg-instruction-methods-errors.td (830 of 1125)
******************** TEST 'CIRCT :: Tools/circt-tblgen/rtg-instruction-methods-errors.td' FAILED ********************
Exit Code: 1
Command Output (stderr):
--
RUN: at line 1: not circt-tblgen -gen-rtg-instruction-methods -I /build/source/test/Tools/circt-tblgen/../../../include -I /build/source/test/Tools/circt-tblgen/../../../llvm/mlir/include /build/source/test/Tools/circt-tblgen/rtg-instruction-methods-errors.td -DTEST_IMM_NO_WRAPPER 2>&1 | /nix/store/0y8ygxmgwq4xsrqpjidrbnc77k2yx40y-llvm-23.0.0-20260129_52dfcab/bin/FileCheck /build/source/test/Tools/circt-tblgen/rtg-instruction-methods-errors.td --check-prefix=IMM_NO_WRAPPER
+ not circt-tblgen -gen-rtg-instruction-methods -I /build/source/test/Tools/circt-tblgen/../../../include -I /build/source/test/Tools/circt-tblgen/../../../llvm/mlir/include /build/source/test/Tools/circt-tblgen/rtg-instruction-methods-errors.td -DTEST_IMM_NO_WRAPPER
+ /nix/store/0y8ygxmgwq4xsrqpjidrbnc77k2yx40y-llvm-23.0.0-20260129_52dfcab/bin/FileCheck /build/source/test/Tools/circt-tblgen/rtg-instruction-methods-errors.td --check-prefix=IMM_NO_WRAPPER
/build/source/test/Tools/circt-tblgen/rtg-instruction-methods-errors.td:52:20: error: IMM_NO_WRAPPER: expected string not found in input
// IMM_NO_WRAPPER: rtg-instruction-methods-errors.td:50:41: error: immediate operand '$imm' must be wrapped in signed() or unsigned()
¦ ¦ ¦ ¦ ¦ ¦ ¦ ¦ ¦^
<stdin>:1:1: note: scanning from here
Included from /build/source/test/Tools/circt-tblgen/rtg-instruction-methods-errors.td:32:
^
Input file: <stdin>
Check file: /build/source/test/Tools/circt-tblgen/rtg-instruction-methods-errors.td
-dump-input=help explains the following input dump.
Input was:
<<<<<<
¦ ¦ ¦ ¦ 1: Included from /build/source/test/Tools/circt-tblgen/rtg-instruction-methods-errors.td:32:·
check:52 X~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ error: no match found
¦ ¦ ¦ ¦ 2: /build/source/test/Tools/circt-tblgen/../../../include/circt/Dialect/RTG/IR/RTGISAAssemblyInterfaces.td:12:9: error: could not find include file 'mlir/IR/Interfaces.td'·
check:52 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
¦ ¦ ¦ ¦ 3: include "mlir/IR/Interfaces.td"·
check:52 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
¦ ¦ ¦ ¦ 4: ^·
check:52 ~~~
¦ ¦ ¦ ¦ 5: Included from /build/source/test/Tools/circt-tblgen/rtg-instruction-methods-errors.td:32:·
check:52 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
¦ ¦ ¦ ¦ 6: /build/source/test/Tools/circt-tblgen/../../../include/circt/Dialect/RTG/IR/RTGISAAssemblyInterfaces.td:12:9: error: Unexpected token at top level·
check:52 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
¦ ¦ ¦ ¦ .
¦ ¦ ¦ ¦ .
¦ ¦ ¦ ¦ .
>>>>>>
--
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels