Open
Conversation
Owner
|
Hi! and holy shit that's a massive PR. Even my browser has trouble loading the changes 💀 I'll need to review the whole thing carefully, so it might take some time. I don't know how to code in ruby and neither have I ever looked at ruby code that much if I'm honest, but I'll see what I can do, Genuinely thank you though, this must've taken you ages to complete. My schedule is pretty tight but I'll definitely come back to this PR whenever needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Briefly explain what this PR does:
This PR provides a wrapper to the basic functionality of VMAware for Ruby, as a native gem. Due to heavy reliance on MSVC, windows is not supported by the gem (as ruby is ucrt-based).