Skip to content

typing: add rule 14 - checks for tie_word_embeddings presence#44988

Open
tarekziade wants to merge 3 commits intomainfrom
tarekziade-rule-tie-word
Open

typing: add rule 14 - checks for tie_word_embeddings presence#44988
tarekziade wants to merge 3 commits intomainfrom
tarekziade-rule-tie-word

Conversation

@tarekziade
Copy link
Collaborator

What does this PR do?

Adds Rule 14

if _tied_weights_keys is present and non-empty in modeling -> Config MUST contain the tie_word_embeddings field

@tarekziade
Copy link
Collaborator Author

run-slow: ibert

@github-actions
Copy link
Contributor

Workflow Run ⚙️

This comment contains run-slow, running the specified jobs:

models: ["models/ibert"]
quantizations: []

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@github-actions
Copy link
Contributor

CI Results

Workflow Run ⚙️

Commit Info

Context Commit Description
RUN 2a68caa7 workflow commit (merge commit)
PR bf1e9854 branch commit (from PR)
main 28af8184 base commit (on main)

✅ No failing test specific to this PR 🎉 👏 !

@tarekziade tarekziade force-pushed the tarekziade-rule-tie-word branch from bf1e985 to e3c3d20 Compare March 25, 2026 12:34
@tarekziade tarekziade changed the title typing: add rule 14 typing: add rule 14 - checks for tie_word_embeddings presence Mar 25, 2026
@github-actions
Copy link
Contributor

[For maintainers] Suggested jobs to run (before merge)

run-slow: blip, ibert, kosmos2, kosmos2_5

@github-actions
Copy link
Contributor

View the CircleCI Test Summary for this PR:

https://huggingface.co/spaces/transformers-community/circle-ci-viz?pr=44988&sha=9ce90f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants