fixed import error with PILImageResampling#44958
Open
josh-kean wants to merge 2 commits intohuggingface:mainfrom
Open
fixed import error with PILImageResampling#44958josh-kean wants to merge 2 commits intohuggingface:mainfrom
josh-kean wants to merge 2 commits intohuggingface:mainfrom
Conversation
Member
|
cc @zucchini-nlp since you were posting in #44933! |
|
|
||
| except Exception: | ||
| PILImageResampling = None | ||
|
|
Member
There was a problem hiding this comment.
imo try/except for loading isn't really desirable. And we know that the only reason to import is type checking, so we can do this
if TYPE_CHECKING:
from .image_utils import PILImageResampling
Btw, I want to see where this is being imported, can you share the whole script and I will reproduce it locally, by uninstalling Pillow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes an import in src/transformers/video_processing_utils.py that was causing the main build to fail
Fixes # 44933
Code Agent Policy
The Transformers repo is currently being overwhelmed by a large number of PRs and issue comments written by
code agents. We are currently bottlenecked by our ability to review and respond to them. As a result,
we ask that new users do not submit pure code agent PRs at this time.
You may use code agents in drafting or to help you diagnose issues. We'd also ask autonomous "OpenClaw"-like agents
not to open any PRs or issues for the moment.
PRs that appear to be fully agent-written will probably be closed without review, and we may block users who do this
repeatedly or maliciously.
This is a rapidly-evolving situation that's causing significant shockwaves in the open-source community. As a result,
this policy is likely to be updated regularly in the near future. For more information, please read
CONTRIBUTING.md.Before submitting
Pull Request section?
to it if that's the case. <- Nonexistant import from image_utils #44933
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.