Conversation
…ty/harden-runner`
The `allowed-endpoints` input only flows to `execFileSync("echo", [content])`
(no shell) and `fs.writeFileSync` (JSON config), neither of which is a
command injection vector.
Fixes #21568
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes an incorrect GitHub Actions sink model that was causing false-positive command-injection findings for step-security/harden-runner (per issue #21568), aligning the CodeQL Actions models with the action’s actual behavior.
Changes:
- Removes the manual
actionsSinkModelentry that labeledinput.allowed-endpointsas acommand-injectionsink.
The `context` input is passed as a single array element through `docker/actions-toolkit` and `@actions/exec` all the way to `child_process.spawn()`, which does not perform shell splitting. No code injection is possible. Fixes #21428
redsun82
changed the title
command-injection sink model for step-security/harden-runnerdocker/build-push-action and step-security/harden-runner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove false positive injection sink models for:
contextinput ofdocker/build-push-action(fixes False positive: docker/build-push-action, context input #21428)allowed-endpointsinput ofstep-security/harden-runner(fixes False positive: Incorrect CodeQL model for step-security/harden-runner action #21568)In both cases, the inputs are passed as single array elements to
child_process.spawn()or similar non-shell APIs, so no injection is possible.