Add retry logic for transient login failures#918
Open
naushkorai wants to merge 1 commit intodocker:masterfrom
Open
Add retry logic for transient login failures#918naushkorai wants to merge 1 commit intodocker:masterfrom
naushkorai wants to merge 1 commit intodocker:masterfrom
Conversation
Adds configurable retry mechanism with basic exponential backoff to handle intermittent failures when authenticating to container registries, particularly GCP (GAR/GCR) where I'm seeing errors intermittently. - Add retry-attempts input (default: 0 for backward compatibility, making it opt in) - Add retry-delay input (default: 5000ms) - Implement exponential backoff retry logic in docker login - Chose to just write a simple retry function vs. going with a library - Retry all errors except 5xxs - I'm seeing intermittent 401 failures - Add tests for retry behavior - Update README with new input parameters Signed-off-by: Naush Korai <naush.korai@mixpanel.com>
naushkorai
force-pushed
the
retry_auth
branch
from
4f9deb3 to
47690b2
Compare
|
I'd love this supported as well. |
|
@thaJeztah Sorry for pinging directly: we're having a lot of transient failures from DockerHub on this action which is degrading our CI. Retry logic like this would be super helpful. I'm sure many other users would benefit. Here's an example from our open-source repo. We're having flakiness due to timeouts today: https://github.com/tensorzero/tensorzero/actions/runs/22406824746/job/64868963743?pr=6569 I'm not sure if this is exactly the solution you'll want. Our team is happy to contribute as well if you'd like a different approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds configurable retry mechanism with basic exponential backoff to handle intermittent failures when authenticating to container registries, particularly GCP (GAR/GCR) where I'm seeing errors intermittently.
Attempting to address #885