fix: improve e2e observability test resilience and diagnostics#641
Draft
Hweinstock wants to merge 1 commit intoaws:mainfrom
Draft
fix: improve e2e observability test resilience and diagnostics#641Hweinstock wants to merge 1 commit intoaws:mainfrom
Hweinstock wants to merge 1 commit intoaws:mainfrom
Conversation
3fd15aa to
421a4e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The observability e2e tests (
logs,logs --level,traces list) are failing consistently in CI across all suites. Root cause: the commands return exit code 1 when CloudWatch log groups or transaction search data are not yet available, but the tests either lack retry or have insufficient retry windows for the CI environment (12 parallel suites hitting CloudWatch simultaneously).Three fixes:
logs supports level filteringnow has retry — it was the only observability test without retry, failing immediately if the log group was not yet available.Related Issue
Closes #
Documentation PR
N/A
Type of Change
Testing
How have you tested the change?
npm run test:unitandnpm run test:integnpm run typechecknpm run lintsrc/assets/, I rannpm run test:update-snapshotsand committed the updated snapshotsThe observability tests pass consistently in local dev account runs. The CI failures should be resolved by the increased retry window and the addition of retry to the level filter test. If failures persist, the improved error messages will now show the actual CLI error output for diagnosis.
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.