fix: use Dag form when materializing asset#64211
Open
Lee-W wants to merge 2 commits intoapache:mainfrom
Open
Conversation
Lee-W
requested review from
bbovenzi,
bugraoz93,
choo121600,
ephraimbuddy,
guan404ming,
jason810496,
pierrejeambrun,
rawwar,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
boring-cyborg
bot
added
area:API
bbovenzi
reviewed
Mar 25, 2026
Comment on lines
+84
to
+86
| const submitError = submitErrorOverride ?? triggerError; | ||
| const submitPending = isPendingOverride ?? isTriggerPending; | ||
| const submitTrigger = onSubmitTrigger ?? triggerDagRun; |
Contributor
There was a problem hiding this comment.
Nit. we can drop "submit" from all of these. The function should also be a verb like "onTrigger"
bbovenzi
reviewed
Mar 25, 2026
Comment on lines
+63
to
+69
| error: submitErrorOverride, | ||
| hasSchedule, | ||
| isPartitioned, | ||
| isPaused, | ||
| isPending: isPendingOverride, | ||
| onClose, | ||
| onSubmitTrigger, |
Contributor
There was a problem hiding this comment.
If we stay with materialize and trigger being two different actions then I think we should remove the direct useTrigger API call from this component. Then we don't need any overrides.
Only keeping pause toggle when submitting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Closes: #63807
What
Use Dag from when materializing the asset
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.