feat: use go.mod when no version inputs specified#660
Open
raeperd wants to merge 5 commits intoactions:mainfrom
Open
feat: use go.mod when no version inputs specified#660raeperd wants to merge 5 commits intoactions:mainfrom
raeperd wants to merge 5 commits intoactions:mainfrom
Conversation
- Add unit tests for auto-detection behavior - Implement go.mod auto-detection in resolveVersionInput() - Explicit inputs still take precedence over auto-detection Related issue: actions#523
Related issue: actions#523
raeperd
changed the title
Resolve merge conflicts: - action.yml: combine auto-detect description with .go-version/.tool-versions support - versions.yml: keep auto-detect-go-mod job alongside new tool-versions/go-version jobs - README.md: keep auto-detect section, adopt main's link to advanced-usage docs - tests: keep auto-detect tests alongside new go-download-base-url tests
Author
|
Hi @aparnajyothi-y @priyagupta108, As a user of this action, this would be a nice quality-of-life improvement — I find myself specifying I saw you both reviewed related changes in #705 and #673, so your feedback here would be really valuable. Happy to make any changes needed. Thank you! |
Follows the pattern from actions#724 where detailed usage docs live in docs/advanced-usage.md rather than README.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds automatic go.mod detection when neither
go-versionnorgo-version-fileis specified. This simplifies workflows for Go projects that already have a go.mod file.Before:
After:
Related issue:
Closes #523
Check list: