Skip to content

shared-config: sync docs Gemfile.lock using main bundler version#415

Open
p-linnane wants to merge 1 commit intomainfrom
sync-docs-gemfile-lock
Open

shared-config: sync docs Gemfile.lock using main bundler version#415
p-linnane wants to merge 1 commit intomainfrom
sync-docs-gemfile-lock

Conversation

@p-linnane
Copy link
Member

Previously, brew was entirely excluded from Gemfile.lock syncing and the docs bundler version was read from the (potentially stale) docs lock. This meant brew/docs and private/docs required manual version bumps.

Now, docs Gemfile.lock files are synced for all repos (including brew), using the bundler version from Library/Homebrew/Gemfile.lock as the single source of truth. This allows the entire ecosystem to sync in one run.

Copilot AI review requested due to automatic review settings March 25, 2026 21:04
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the shared-config sync script to treat Homebrew/brew’s Library/Homebrew/Gemfile.lock as the single source of truth for the Bundler version when syncing docs lockfiles across repositories, enabling a full ecosystem sync (including brew/docs) in one run.

Changes:

  • Sync docs/Gemfile.lock for brew while continuing to skip non-docs lockfiles in brew (source of truth).
  • Derive the Bundler version from Library/Homebrew/Gemfile.lock for all lockfile updates (including docs).
  • Refine the script’s selection logic for which Gemfile.lock files to update.
Comments suppressed due to low confidence (1)

.github/actions/sync/shared-config.rb:288

  • The return value of system "bundle", "update", ... isn’t checked. If bundle update fails (e.g., missing gems, network issues), the script will continue and may report “No changes detected” instead of failing the sync. Consider aborting on failure (e.g., abort/raise when system returns false) so the action fails loudly.
      puts "Running bundle update (with Bundler #{bundler_version})..."
      system "bundle", "update", "--ruby", "--bundler=#{bundler_version}", "--quiet", out: "/dev/null"
    end

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Patrick Linnane <patrick@linnane.io>
@p-linnane p-linnane force-pushed the sync-docs-gemfile-lock branch from 7aa6d35 to c702cde Compare March 25, 2026 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants