shared-config: sync docs Gemfile.lock using main bundler version#415
Open
shared-config: sync docs Gemfile.lock using main bundler version#415
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the shared-config sync script to treat Homebrew/brew’s Library/Homebrew/Gemfile.lock as the single source of truth for the Bundler version when syncing docs lockfiles across repositories, enabling a full ecosystem sync (including brew/docs) in one run.
Changes:
- Sync
docs/Gemfile.lockforbrewwhile continuing to skip non-docs lockfiles inbrew(source of truth). - Derive the Bundler version from
Library/Homebrew/Gemfile.lockfor all lockfile updates (including docs). - Refine the script’s selection logic for which
Gemfile.lockfiles to update.
Comments suppressed due to low confidence (1)
.github/actions/sync/shared-config.rb:288
- The return value of
system "bundle", "update", ...isn’t checked. Ifbundle updatefails (e.g., missing gems, network issues), the script will continue and may report “No changes detected” instead of failing the sync. Consider aborting on failure (e.g.,abort/raisewhensystemreturns false) so the action fails loudly.
puts "Running bundle update (with Bundler #{bundler_version})..."
system "bundle", "update", "--ruby", "--bundler=#{bundler_version}", "--quiet", out: "/dev/null"
end
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Patrick Linnane <patrick@linnane.io>
7aa6d35 to
c702cde
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, brew was entirely excluded from
Gemfile.locksyncing and the docs bundler version was read from the (potentially stale) docs lock. This meant brew/docs and private/docs required manual version bumps.Now, docs
Gemfile.lockfiles are synced for all repos (including brew), using the bundler version fromLibrary/Homebrew/Gemfile.lockas the single source of truth. This allows the entire ecosystem to sync in one run.