Fix Mass Assignment in Assistants Endpoints

[christopherholland-workday]

Flowise-323 (See comments on Assistants)

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a potential security vulnerability by refactoring the assistant creation and update logic. Instead of using a broad Object.assign which could lead to mass assignment, dedicated functions now explicitly assign allowed fields. This change enhances the robustness and security of the API endpoints related to assistant management.

Highlights

• Security Fix: Implemented specific field assignment functions (applyAssistantCreateFields and applyAssistantUpdateFields) to prevent mass assignment vulnerabilities in assistant creation and update operations.
• Code Refactoring: Replaced generic Object.assign calls with explicit field assignments, improving code clarity and security by ensuring only intended fields are modified.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors assistant creation and update logic by introducing applyAssistantCreateFields and applyAssistantUpdateFields functions, replacing direct Object.assign calls. However, the review identified two critical Insecure Direct Object Reference (IDOR) vulnerabilities. Firstly, workspaceId is directly assigned from the request body in applyAssistantCreateFields, which could allow an attacker to create assistants in unauthorized workspaces. Secondly, credential is assigned from the request body in both new helper functions without validation against the user's workspace, potentially enabling the use of unauthorized credentials. The reviewer suggests passing workspaceId as a trusted parameter and implementing server-side validation for credentials.

[christopherholland-workday]

/gemini review

[gemini-code-assist]

Code Review

This pull request refactors the assistant creation and update processes to enhance security and maintainability. It centralizes workspaceId handling, introduces a findAccessibleCredential function for secure credential access, and replaces Object.assign with explicit field assignment functions (applyAssistantCreateFields, applyAssistantUpdateFields) to prevent mass assignment vulnerabilities. The review suggests further improving type safety in these new assignment functions by defining specific types for the body parameters instead of using any, which would clarify their contracts and reinforce the mass assignment prevention.