-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Description
This issue is automatically created based on existing pull request: #40623: [PHPDOC] Update argument type in Magento\Customer\Api\Data\CustomerInterface::setConfirmation()
Description (*)
This PR fix the bad phpdoc in Magento\Customer\Api\Data\CustomerInterface::setConfirmation(). The argument $confirmation can be null.
Here is an example where the type null is used :
magento2/app/code/Magento/Customer/Model/ForgotPasswordToken/ConfirmCustomerByToken.php
Lines 60 to 66 in 57bad41
| private function resetConfirmation(CustomerInterface $customer): void | |
| { | |
| // skip unnecessary address and customer validation | |
| $customer->setData('ignore_validation_flag', true); | |
| $customer->setConfirmation(null); | |
| $this->customerRepository->save($customer); |
With PHPSTAN is very complicated to setup the project with level 5 or higher :(
Related Pull Requests
None
Fixed Issues (if relevant)
None
Manual testing scenarios (*)
Setup PHPSTAN with level 5 or higher and run check.
Questions or comments
The quality of Magento code needs to be improved so that it is easier to use the code quality tools (phpstan, rector, ...) ❤️
Contribution checklist (*)
- Pull request has a meaningful description of its purpose
- All commits are accompanied by meaningful commit messages
- All new or changed code is covered with unit/integration tests (if applicable)
- README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
- All automated tests passed successfully (all builds are green)
Metadata
Metadata
Assignees
Labels
Type
Projects
Status