refactor(app): Migrate quick transfer dashboard to protocols view (#20493)

Closes AUTH-2561

This commit refactors the UX flow for creating and viewing existing QT
protocol runs. The QT Dashboard is removed. Instead, existing QT
protocols are accessible from the protocols view. A new button serves as
the CTA for creating a new quick transfer. Existing flow behavior is
preserved.

Author: mjhuff

app/src/App/OnDeviceDisplayApp.tsx

@@ -37,7 +37,6 @@ import { NetworkSetupMenu } from '/app/pages/ODD/NetworkSetupMenu'
 import { ProtocolDashboard } from '/app/pages/ODD/ProtocolDashboard'
 import { ProtocolDetails } from '/app/pages/ODD/ProtocolDetails'
 import { ProtocolSetup } from '/app/pages/ODD/ProtocolSetup'
-import { QuickTransferDashboard } from '/app/pages/ODD/QuickTransferDashboard'
 import { QuickTransferDetails } from '/app/pages/ODD/QuickTransferDetails'
 import { RobotDashboard } from '/app/pages/ODD/RobotDashboard'
 import { RobotSettingsDashboard } from '/app/pages/ODD/RobotSettingsDashboard'
@@ -85,7 +84,6 @@ export const ON_DEVICE_DISPLAY_PATHS = [
   '/network-setup/wifi',
   '/protocols',
   '/protocols/:protocolId',
-  '/quick-transfer',
   '/quick-transfer/new',
   '/quick-transfer/:quickTransferId',
   '/robot-settings',
@@ -126,8 +124,6 @@ function getPathComponent(
       return <ProtocolDashboard />
     case '/protocols/:protocolId':
       return <ProtocolDetails />
-    case '/quick-transfer':
-      return <QuickTransferDashboard />
     case '/quick-transfer/new':
       return <QuickTransferFlow />
     case '/quick-transfer/:quickTransferId':

app/src/assets/localization/en/protocol_info.json

@@ -67,6 +67,7 @@
   "protocol_title": "Protocol - {{protocol_name}}",
   "protocol_upload_failed": "Protocol upload failed. Fix the error and try again",
   "protocols": "Protocols",
+  "quick_transfer": "Quick transfer",
   "required_cal_data_title": "Calibration Data",
   "required_quantity_title": "Quantity",
   "required_type_title": "Type",

app/src/assets/localization/en/quick_transfer.json

@@ -138,7 +138,6 @@
   "push_out_description": "Helps ensure all liquid leaves the tip",
   "push_out_value": "{{volume}} µL",
   "push_out_volume": "Push out volume (µL)",
-  "quick_transfer": "Quick transfer",
   "quick_transfer_volume": "Quick Transfer {{volume}}µL",
   "reservoir": "Reservoirs",
   "reset_kind_settings": "Reset {{transferName}} settings?",

app/src/organisms/ODD/Navigation/__tests__/Navigation.test.tsx

@@ -53,9 +53,6 @@ describe('Navigation', () => {
     const allProtocols = screen.getByRole('link', { name: 'Protocols' })
     expect(allProtocols).toHaveAttribute('href', '/protocols')
 
-    const quickTransfer = screen.getByRole('link', { name: 'Quick Transfer' })
-    expect(quickTransfer).toHaveAttribute('href', '/quick-transfer')
-
     const instruments = screen.getByRole('link', { name: 'Instruments' })
     expect(instruments).toHaveAttribute('href', '/instruments')
 

app/src/organisms/ODD/Navigation/index.tsx

@@ -39,7 +39,6 @@ import type { ON_DEVICE_DISPLAY_PATHS } from '/app/App/OnDeviceDisplayApp'
 
 const NAV_LINKS: Array<(typeof ON_DEVICE_DISPLAY_PATHS)[number]> = [
   '/protocols',
-  '/quick-transfer',
   '/instruments',
   '/robot-settings',
 ]
@@ -114,8 +113,6 @@ export function Navigation(props: NavigationProps): JSX.Element {
         return t('protocols')
       case '/robot-settings':
         return t('settings')
-      case '/quick-transfer':
-        return t('quick_transfer')
       default:
         return ''
     }

app/src/organisms/ODD/QuickTransferFlow/SummaryAndSettings.tsx

@@ -140,7 +140,7 @@ export function SummaryAndSettings(
       files: [protocolFile],
       protocolKind: 'quick-transfer',
     }).then(() => {
-      navigate('/quick-transfer')
+      navigate('/protocols')
     })
     trackEventWithRobotSerial({
       name: ANALYTICS_QUICK_TRANSFER_SAVE_FOR_LATER,

app/src/organisms/ODD/QuickTransferFlow/index.tsx

@@ -53,7 +53,7 @@ export const QuickTransferFlow = (): JSX.Element => {
         step: currentStep,
       },
     })
-    navigate('/quick-transfer')
+    navigate('/protocols')
   }, true)
 
   const exitButtonProps: ComponentProps<typeof SmallButton> = {

app/src/organisms/ODD/RunningProtocol/ConfirmCancelRunModal/__tests__/ConfirmCancelRunModal.test.tsx

@@ -71,7 +71,6 @@ describe('ConfirmCancelRunModal', () => {
       isActiveRun: true,
       runId: RUN_ID,
       setShowConfirmCancelRunModal: mockFn,
-      isQuickTransfer: false,
     }
 
     vi.mocked(useStopRunMutation).mockReturnValue({
@@ -169,7 +168,6 @@ describe('ConfirmCancelRunModal', () => {
     props = {
       ...props,
       isActiveRun: false,
-      isQuickTransfer: true,
     }
 
     vi.mocked(useNotifyRunQuery).mockReturnValue({
@@ -184,14 +182,13 @@ describe('ConfirmCancelRunModal', () => {
 
     expect(mockDismissCurrentRun).toHaveBeenCalled()
     expect(mockTrackProtocolRunEvent).toHaveBeenCalled()
-    expect(mockNavigate).toHaveBeenCalledWith('/quick-transfer')
+    expect(mockNavigate).toHaveBeenCalledWith('/protocols')
   })
 
   it('when quick transfer run with protocolId is stopped, it navigates to protocol-specific quick transfer', () => {
     props = {
       ...props,
       isActiveRun: false,
-      isQuickTransfer: true,
       protocolId: 'test-protocol-id',
     }
 
@@ -207,9 +204,7 @@ describe('ConfirmCancelRunModal', () => {
 
     expect(mockDismissCurrentRun).toHaveBeenCalled()
     expect(mockTrackProtocolRunEvent).toHaveBeenCalled()
-    expect(mockNavigate).toHaveBeenCalledWith(
-      '/quick-transfer/test-protocol-id'
-    )
+    expect(mockNavigate).toHaveBeenCalledWith('/protocols/test-protocol-id')
   })
 
   it('when run with protocolId is stopped, it navigates to protocol page', () => {

app/src/organisms/ODD/RunningProtocol/ConfirmCancelRunModal/index.tsx

@@ -27,15 +27,13 @@ interface ConfirmCancelRunModalProps {
   runId: string
   setShowConfirmCancelRunModal: (showConfirmCancelRunModal: boolean) => void
   isActiveRun: boolean
-  isQuickTransfer: boolean
   protocolId?: string | null
 }
 
 export function ConfirmCancelRunModal({
   runId,
   setShowConfirmCancelRunModal,
   isActiveRun,
-  isQuickTransfer,
   protocolId,
 }: ConfirmCancelRunModalProps): JSX.Element {
   const { t } = useTranslation(['run_details', 'shared'])
@@ -83,11 +81,7 @@ export function ConfirmCancelRunModal({
       trackProtocolRunEvent({ name: ANALYTICS_PROTOCOL_RUN_ACTION.CANCEL })
       if (!isActiveRun) {
         dismissCurrentRun(runId)
-        if (isQuickTransfer && protocolId != null) {
-          navigate(`/quick-transfer/${protocolId}`)
-        } else if (isQuickTransfer) {
-          navigate('/quick-transfer')
-        } else if (protocolId != null) {
+        if (protocolId != null) {
           navigate(`/protocols/${protocolId}`)
         } else {
           navigate('/protocols')